search

cancerDHC / ccdhmodel

CRDC-H model in LinkML, developed by the Center for Cancer Data Harmonization (CCDH)
https://cancerdhc.github.io/ccdhmodel/
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

Add support for storing and emiting Decimals in the CRDC-H instance data #131

Open gaurav opened 3 years ago

gaurav commented 3 years ago

CRDC-H defines a decimal type based on Python's Decimal type. Unfortunately, this doesn't work correctly at present:

  1. Trying to create a crdch_model.Decimal() with a Python Decimal works, but when you try writing it out as YAML, results in the following error: yaml.representer.RepresenterError: ('cannot represent an object', Decimal('20653'))
  2. Trying to use the trick of manually setting the value doesn't work, because you can either set this value as a string (in which case it fails JSON validation, which expected a decimal), as a float (which would incorrectly mess up decimals), or as an integer (which truncates non-integral decimals).

You can see these errors in PR https://github.com/cancerDHC/example-data/pull/22, but we should move some examples into this repo and then try to fix them, probably in LinkML.

There might be a solution to this problem here: https://stackoverflow.com/a/47346704/27310