cancerDHC / ccdhmodel

CRDC-H model in LinkML, developed by the Center for Cancer Data Harmonization (CCDH)
https://cancerdhc.github.io/ccdhmodel/
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

Be more specific about specific kinds of observation types #133

Open gaurav opened 3 years ago

gaurav commented 3 years ago

In the CRDC Tech talk just now, Denise Warzel pointed out that there were different kinds of weights, and that we should be very specific of which kind of weight we mean here.

bfurner commented 3 years ago

Here is the example that raised the comment from Denise. Her suggestion was to use a more granular concept for this observation_type (e.g. current biospecimen weight - C181724) rather than the more generic concept of 'weight'.

quantity_measure:
  - observation_type:
      coding:                                                 # type = Coding 
        - code: C25208                                            
          label: Weight                                       
          system: http://ncithesaurus.nci.nih.gov             
          tag:                                               
            - harmonized                                      
    value_quantity:                                           # type = Quantity
      value_decimal: 45
      unit:
        coding:                                               # type = Coding 
          - code: C28253                                            
            label: Milligram                                     
            system: http://ncithesaurus.nci.nih.gov             
            tag:                                              
              - harmonized