Can we switch to "$defs" instead of "definitions", and all the $ref be updated accordingly, for the generated JSON Schema?

cancerDHC / ccdhmodel

CRDC-H model in LinkML, developed by the Center for Cancer Data Harmonization (CCDH)

https://cancerdhc.github.io/ccdhmodel/

BSD 3-Clause "New" or "Revised" License

16 stars 8 forks source link

Can we switch to "$defs" instead of "definitions", and all the $ref be updated accordingly, for the generated JSON Schema? #86

Open ShahimEssaid opened 3 years ago

gaurav commented 3 years ago

Yes, we can! I've filed this issue with LinkML at https://github.com/linkml/linkml/issues/305, and we'll work on this as soon as we're done with PR #75.

sujaypatil96 commented 3 years ago

Outcome of issue #305 on linkml repo should result in a change from definitions to $defs on line #4 in the ccdh data model.

sujaypatil96 commented 3 years ago

PR #311 which fixes this issue on the linkml repo has been merged. I think we're ready to close out this issue.

gaurav commented 3 years ago

I'll pull the latest LinkML into our fork, regenerate the artifacts, and then send them to Shahim to confirm that this is what he needs. Once he's confirmed that, we can close this issue. Thanks so much for fixing this, Sujay!

gaurav commented 3 years ago

I've updated the version of LinkML we use in PR #109. I've also added a test to make sure that the JSON Schema is valid, which unfortunately it is not (I think because of #85). I'll keep working on this until this JSON Schema can be fully validated.

@ShahimEssaid: Could you please check https://github.com/cancerDHC/ccdhmodel/pull/109/files#diff-456d10c2832bcf26f95f8adf860b978802250d5def49998ebe52b11820f65ba0 and check that this is what you needed? Please let us know if there's any other related change we need to make!