Replace pipenv with poetry

Thanks for explaining, Gaurav

On Dec 9, 2021, at 2:53 PM, Gaurav Vaidya @.***> wrote:

@gaurav commented on this pull request.

In .github/workflows/pytest.yaml https://github.com/cancerDHC/example-data/pull/41#discussion_r766107617:

id: cache-poetry uses: @.*** with:

path: ~/.local/share/virtualenvs

key: ${{ runner.os }}-pipenv-${{ hashFiles('**/Pipfile.lock') }}

name: Install dependencies

if: steps.cache-pipenv.outputs.cache-hit != 'true'

run: |

pipenv install --deploy --dev

path: ~/.local

key: ${{ runner.os }}-python-${{ matrix.python-version }}-poetry-${{ hashFiles('**/poetry.lock') }} Sujay: Yup, that makes sense! Fixed in 41522b9 https://github.com/cancerDHC/example-data/commit/41522b9f898fd516bbf65ad11a97f520c1b1e602.

Mark:

Is this PR primarily about getting poetry to work with the GH actions? Is the ability to use poetry in a locally cloned repo a direct side effect of that? A new user would still have to install the poetry application and run the poetry install command before doing any local development or testing. right?

It's primarily about getting Poetry settings in here so that you can run the local scripts and tests and things with poetry run pytest ..., but one way of testing that we've set that up correctly is that to ensure that GitHub Actions can run the tests via Poetry as well.

This caching is allows us to keep a copy of the installed dependencies on the GitHub Actions system https://github.com/snok/install-poetry#caching-the-poetry-installation -- that way, we don't need to redownload the dependencies every time we run the tests.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/cancerDHC/example-data/pull/41#discussion_r766107617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAEX6OD7ZK2SX23QYJA5RTUQECLVANCNFSM5IKQSIMQ.

cancerDHC / example-data

Replace pipenv with poetry #41