Discussion notebook - Githubissues

cancerDHC / example-data

This repository is intended to act as a store of example data files from across the NCI Cancer Research Data Commons (CRDC) nodes in a number of formats.

MIT License

0 stars 3 forks source link

Discussion notebook #42

Open turbomam opened 2 years ago

turbomam commented 2 years ago

salvaged from Sujay's PDC conversion branch

as discussed 2021-11-18

gaurav commented 2 years ago

So there are three commits in this PR:

990c973: Sujay's original commits to pdc_to_crdch_transformation.ipynb, which is also included in PR #37.
809409d: Mark's changes to min_csos.ipynb
d30d205: Mark's changes to pdc_to_crdch_transformation.ipynb, but he mentions that this includes "no real edits"

Therefore I propose that we delete both 990c973 and d30d205 from this PR, leaving only 809409d.

@turbomam Does that look right to you?

turbomam commented 2 years ago

@turbomam Does that look right to you?

yes. I'm looking into how to do that now.

turbomam commented 2 years ago

I'd like to take this git rebase -i HEAD~n approach

gaurav commented 2 years ago

Yup, that's what I would do! (I know it as git rebase -i HEAD^^^^ approach, which I think is equivalent to HEAD~4). I would make a backup of your original branch before messing with this, i.e.

$ git checkout -b backup1
$ git checkout discussion_notebook
$ git rebase -i HEAD^^^^

That way, if you mess things up, you can delete discussion_notebook and recreate it from backup1. Once you're happy with discussion_notebook, you will need to use git push origin discussion_notebook -f to force-replace the branch on GitHub with your branch. Have fun!