search

cancerDHC / sheet2linkml

Python package for conversion of Google Sheet to LinkML for CCDH
Apache License 2.0
1 stars 3 forks source link

README: explicit poetry install instructions #2

Closed turbomam closed 3 years ago

turbomam commented 3 years ago

Are they any special instructions for installing poetry? I jut did pip install poetry. We could add that as an instruction in the README after 

python -m venv .venv
source .venv/bin/activate

and before

poetry build

turbomam commented 3 years ago

poetry build? poetry install?

sujaypatil96 commented 3 years ago

I think the developer documentation in the CONTRIBUTING.md file from this repo do a good job of addressing this?

turbomam commented 3 years ago

I think the developer documentation in the CONTRIBUTING.md file from this repo do a good job of addressing this?

Yeah, that is pretty good documentation. The usage of poetry is very clear in CONTRIBUTING.md but I would says that we could be more explicit about installing poetry, since it may be unfamiliar to some people in the LinkML or CRDC communities.

turbomam commented 3 years ago

I copied the link to poetry installation notes from the README.md to the CONTRIBUTING.md in PR #16 . @sujaypatil96 if you approve that or suggest an alternative, I would say this issue could be closed.

turbomam commented 3 years ago

PR #16 was approved and merged, so closing this issue