cancerDHC / tools

A repository for the work of the Tools workstream for CCDH
2 stars 1 forks source link

Test grouping terms in mapping tool via NCImt hierarchy #20

Open balhoff opened 3 years ago

balhoff commented 3 years ago

See https://github.com/cancerDHC/tools/issues/7#issuecomment-693516046

gaurav commented 3 years ago

Also covered by https://github.com/gaurav/umls-rrf-scala/issues/3

decorons commented 3 years ago

Are your referring to NCI Metathesaurus hierarchy or NCI Thesaurus hierarchy for this activity title? Thanks. Sherri

gaurav commented 3 years ago

I don't think we'd ever need to use the NCI Thesaurus hierarchy -- if we have an exact match to an NCIt term, then we're done, and if we have a broad match, I don't think there's any way of using the hierarchy to improve the match. So, in practice we'd only need to use the NCI Metathesaurus hierarchy here.

My idea is to use two pieces of information from the NCI Metathesaurus to try to group terms that we don't have a match for (and, possibly, to validate other matches, see #24):

That's my plan at the moment -- let me know if there's some way to use either NCIt/NCImt hierarchies that I don't know about!

decorons commented 3 years ago

Thanks, Gaurav. Clever. I think I get it. It may be a more general purpose approach for non NCIt terms. Forwarded to Gilberto and Lyuba who also attend the terminology meetings I think. Sherri

From: Gaurav Vaidya notifications@github.com Date: Monday, November 9, 2020 at 12:08 PM To: cancerDHC/tools tools@noreply.github.com Cc: De Coronado, Sherri (NIH/NCI) [E] decorons@mail.nih.gov, Comment comment@noreply.github.com Subject: Re: [cancerDHC/tools] Test grouping terms in mapping tool via NCImt hierarchy (#20)

I don't think we'd ever need to use the NCI Thesaurus hierarchy -- if we have an exact match to an NCIt term, then we're done, and if we have a broad match, I don't think there's any way of using the hierarchy to improve the match. So, in practice we'd only need to use the NCI Metathesaurus hierarchy here.

My idea is to use two pieces of information from the NCI Metathesaurus to try to group terms that we don't have a match for (and, possibly, to validate other matches, see #24https://github.com/cancerDHC/tools/issues/24):

That's my plan at the moment -- let me know if there's some way to use either NCIt/NCImt hierarchies that I don't know about!

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/cancerDHC/tools/issues/20#issuecomment-724147081, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVZR4EGXEHYP6WDU5RNSWLSPAOXHANCNFSM4SPQOPPA.

gaurav commented 3 years ago

Sounds good, Sherri! I'd love to know what they make of this plan.