search

cancerDHC / tools

A repository for the work of the Tools workstream for CCDH
2 stars 1 forks source link

Put the "Entity" class back into the model #34

Closed gaurav closed 3 years ago

gaurav commented 3 years ago

Note from @bfurner on Slack:

in the MVPv0 version of the model (https://raw.githubusercontent.com/cancerDHC/ccdhmodel/mvpv0/model/entities.yaml), there was a “base class” (Entity) which all of our specific classes inherited from. that is useful for cases where we want to bind a property to an “anything” class. not sure how much effort it would be to implement that in the v1, but it would be useful from the modeling side

gaurav commented 3 years ago

There isn't an actual Entity sheet yet -- we should define a blank Entity entity for now, and set it as the parent of all the other entities.

gaurav commented 3 years ago

Implemented in https://github.com/cancerDHC/ccdhmodel/pull/21.