search

cancerit / cgpCaVEManWrapper

Reference implementation of CGP workflow for CaVEMan SNV analysis
http://cancerit.github.io/cgpCaVEManWrapper/
GNU Affero General Public License v3.0
6 stars 3 forks source link

Feature/fix recent issues #43

Closed rulixxx closed 4 years ago

rulixxx commented 5 years ago

Trying to do some simple fixes to the wrapper for the two issues that were pending. Also made the indentation consistent for all the script.

keiranmraine commented 5 years ago

Looks good, but won't merge until we have the docker internal CI running to test it fully.

rulixxx commented 4 years ago

Made a rebase to bring the DockerFile and other changes from dev into this branch.

keiranmraine commented 4 years ago

FYI: @rulixxx the preferred method is to merge dev into your feature branch. I know it adds an additional commit, but it is clear where in the chain the changes were added into the branch.

keiranmraine commented 4 years ago

@rulixxx can we close this (unmerged) until it is ready and then start the review process at that point.