cancervariants / fusion-curation

MIT License
2 stars 0 forks source link

feat!: use latest object schemas and dependency releases #293

Closed katiestahl closed 2 months ago

katiestahl commented 3 months ago

close #272

korikuzma commented 2 months ago

Not sure if this was caused by this PR. We can create a new issue for this. Selected `TPM3::NTRK1 Exon Junction. Then I added a linker sequence and it is doing this.

https://github.com/user-attachments/assets/28547665-9d7a-4495-be73-d20b5577fcab

korikuzma commented 2 months ago

This is from the same previous example https://github.com/user-attachments/assets/98509c0a-855d-4d19-a451-fc6358fc0013

jsstevenson commented 2 months ago

Not sure if this was caused by this PR. We can create a new issue for this. Selected `TPM3::NTRK1 Exon Junction. Then I added a linker sequence and it is doing this.

that's interesting, looks like a concurrency bug. @katiestahl and I can investigate further.

katiestahl commented 2 months ago

Not sure if this was caused by this PR. We can create a new issue for this. Selected `TPM3::NTRK1 Exon Junction. Then I added a linker sequence and it is doing this.

Screen.Recording.2024-08-07.at.09.57.09.mov

dangit, yeah this is because if you make any changes to the structure when the nomenclature request is still returning, it'll end up in this weird loop. I've seen it before and tried implementing a fix, but it looks like it runs deeper than my fix. we need to cancel any async requests when the structure changes. Anyway, I think it is unrelated to this PR

korikuzma commented 2 months ago

@katiestahl @jsstevenson created a new issue for this (#311). Can we merge this PR?

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 1 day(s) with no activity. Please review this PR.