search

cancervariants / fusion-curation

MIT License
2 stars 0 forks source link

Async issues in tests #303

Open jsstevenson opened 1 month ago

jsstevenson commented 1 month ago

Describe the bug

Running the constructor tests yields an assortment of errors related to asynchronous initialization of and access to FUSOR resources. This is bad.

Steps to reproduce

pytest tests/integration/test_constructors.py

Expected behavior

They should pass, or at least fail by value

Current behavior

Instead they produce a lot of varying async-related errors, particularly if you only call one at a time.

Possible reason(s)

No response

Suggested fix

No response

Branch, commit, and/or version

staging branch

Screenshots

No response

Environment details

mac

Additional details

No response

Contribution

Yes, I can create a PR for this fix.

jsstevenson commented 1 month ago

Also -- double check these values in test_complete_gene:

    # TODO these aren't matching anymore, and the results here look kind of weird.
    # we should double check in a separate issue
    # assert response_json["prev_symbols"] == [
    #     ["A", "LOC100420587", "ncbigene:100420587", "NCBI:NC_000019.10", "-"]
    # ]
    # assert response_json["aliases"] == [
    #     ["A", "LOC110467529", "ncbigene:110467529", "NCBI:NC_000021.9", "+"]
    # ]
jsstevenson commented 1 month ago

And -- rather than checking exact values in test_complete_domain, have an example of some canonically important domain to check for