search

cancervariants / fusion-curation

MIT License
2 stars 0 forks source link

`SEQREPO_DATA_PATH` deafult value mismatch #304

Closed korikuzma closed 1 month ago

korikuzma commented 1 month ago

Describe the bug

The README default and curfu default value for SEQREPO_DATA_PATH are different

Steps to reproduce

NA

Expected behavior

I expect the default value in README to match what is set as the default in curfu

Current behavior

The README says the default value for SEQREPO_DATA_PATH is /usr/local/share/seqrepo/latest, but it's actually set to: https://github.com/cancervariants/fusion-curation/blob/9f64b22b63cbb9a42b260cc432959fa560372cad/server/src/curfu/__init__.py#L54``

Possible reason(s)

No response

Suggested fix

I think that the default value in curfu should be changed to /usr/local/share/seqrepo/latest

Branch, commit, and/or version

branch: staging commit: 9f64b22

Screenshots

No response

Environment details

NA

Additional details

No response

Contribution

None

jsstevenson commented 1 month ago

Also, this should probably be SEQREPO_ROOT_DIR for consistency

jsstevenson commented 1 month ago

closed in #308