cancervariants / fusion-curation

MIT License
2 stars 0 forks source link

Include more information on static assets #307

Open korikuzma opened 1 month ago

korikuzma commented 1 month ago

Feature description

On staging branch (9f64b22):

Acquire two sets of static assets and place all of them within the server/src/curfu/data directory:

I had thought I needed to acquire these files myself. It might be good to update the README to state that these are downloaded automatically from the public vicc-services/curfu s3 bucket when starting the service.

Use case

It might just be a me problem, but I thought I had to acquire these myself. So being explicit that these are downloaded from s3 bucket might prevent others confusion.

Proposed solution

No response

Alternatives considered

No response

Implementation details

No response

Potential Impact

No response

Additional context

No response

Contribution

None

korikuzma commented 1 month ago

Also, my data directory does not look like:

server/src/curfu/data
├── domain_lookup_2022-01-20.tsv
├── gene_aliases_suggest_20211025.tsv
├── gene_assoc_with_suggest_20211025.tsv
├── gene_labels_suggest_20211025.tsv
├── gene_prev_symbols_suggest_20211025.tsv
├── gene_symbols_suggest_20211025.tsv
└── gene_xrefs_suggest_20211025.tsv

It looks like:

server/src/curfu/data
├── domain_lookup_20220120.tsv
├── gene_suggest_20230803.csv

@jsstevenson @katiestahl is this expected?

jsstevenson commented 1 month ago

@korikuzma yeah I think we condensed the suggestion files at one point. We'll need to update that part of the README as well.