cancervariants / metakb

Central repository for the VICC metakb web application
MIT License
15 stars 4 forks source link

Handling multiple MOA therapy objects (`Hormone` and `Chemotherapy`) #250

Open korikuzma opened 10 months ago

korikuzma commented 10 months ago

Previously classified Combination, Immunotherapy, Radiation and Targeted Therapy as combinations. We had skipped Hormone and Chemotherapy.

@wesleygoar :

I do think Chemotherapy should exist in the combination therapy group since chemo is often a part of combo therapy regimes.

Going to wait for Alex to get back to confirm this and see how to handle Hormone

korikuzma commented 8 months ago

@ahwagner Can you comment on this?

ahwagner commented 8 months ago

While true that chemotherapy is often (though not always) a multi-agent regimen, I disagree that we should report chemotherapy as a "CombinationTherapy" instance. The intent of that class is to state that all listed therapeutics are used in combination. If only one therapeutic concept (chemotherapy) is listed, this misuses the semantics of the class, and may be technically inaccurate in the case of single-agent chemotherapy regimens.

The same applies to all of the above concepts.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 45 days with no activity. Please make a comment for triaging or closing the issue.

korikuzma commented 5 months ago

We still want to add this