`metakb.harvesters.base.Harvester.create_json` shouldn't be reimplemented by child classes

cancervariants / metakb

Central repository for the VICC metakb web application

MIT License

14 stars 4 forks source link

`metakb.harvesters.base.Harvester.create_json` shouldn't be reimplemented by child classes #337

Closed jsstevenson closed 1 month ago

jsstevenson commented 1 month ago

I think the redundancy is because different sources have their own object structures, but I'm pretty sure we can abstract that instead of repeating so much code.

korikuzma commented 1 month ago

As I was looking at this, I also don't think we need to create instance vars for the data

korikuzma commented 1 month ago

This was done in #338