search

cancervariants / metakb

Central repository for the VICC metakb web application
MIT License
15 stars 4 forks source link

Normalizers fail silently #362

Closed jsstevenson closed 2 months ago

jsstevenson commented 3 months ago

Currently, the normalizer methods catch all errors and log them as warnings. It's pretty easy to miss the presence of critical errors -- I really don't think we should be doing such broad try/catch blocks, and we definitely should be logging stuff like this above "warning"

korikuzma commented 3 months ago

I think a general issue about fixing logging levels should be made in our repos. I’ve definitely been guilty of inconsistencies

korikuzma commented 3 months ago

I’m not sure if an issue has been made about credentials expiring in normalizers. I think for this exception type, we should exit and raise an exception

jsstevenson commented 3 months ago

I’m not sure if an issue has been made about credentials expiring in normalizers. I think for this exception type, we should exit and raise an exception

Yeah, @korikuzma, this is where I first noticed it -- it's especially troublesome when doing a big transform because it still tries for every entity type, every time, even though the normalizer services are unavailable, and then when you're done you've spent ten minutes to produce no records.

github-actions[bot] commented 2 months ago

Closed by #378.