search

candango / firenado

Web Framework that extends Tornado Web organizing the application, and adding extra features.
Apache License 2.0
12 stars 9 forks source link

Fix python 3.9 warnings #328

Closed piraz closed 3 years ago

piraz commented 3 years ago

When firenado starts on python 3.9 those warnings are displayed:

~/venvs/sincenv/lib64/python3.9/site-packages/cartola/fs.py:54: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if filename_x[-1].strip() is not '':
~/venvs/sincenv/lib64/python3.9/site-packages/firenado/tornadoweb.py:383: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key is 'ignore_component':
~/venvs/sincenv/lib64/python3.9/site-packages/firenado/tornadoweb.py:385: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key is 'component':
~/venvs/sincenv/lib64/python3.9/site-packages/firenado/tornadoweb.py:529: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key is 'ignore_component':
~/venvs/sincenv/lib64/python3.9/site-packages/firenado/tornadoweb.py:531: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key is 'component':
tirkarthi commented 3 years ago

I have created https://github.com/candango/firenado/pull/329 as a fix. These used to be deprecation warnings before they were made syntax warning in Python 3.8 and above.