candango / firenado

Web Framework that extends Tornado Web organizing the application, and adding extra features.
Apache License 2.0
12 stars 9 forks source link

Remove gen.coroutine from ProcessLauncher #402

Closed piraz closed 2 years ago

piraz commented 2 years ago

ProcessLaucher is still using gen.coroutine to deliver pexpect execution asynchronously, let's get that changed to async methods.

We don't need the shutdown to be asynchronous also.

Let's fix the launcher example. It is having a firenado.conf collision between both apps, the launcher app(original one) and charge(the one being launched by launcher). I think we need ProcessLauncher to be executed in a callback routine instead of a component initialize method.