candcconsulting / GroupingandMapping

MIT License
4 stars 2 forks source link

MassProperties - Performance #7

Closed candcconsulting closed 1 year ago

candcconsulting commented 1 year ago

With the move to MassProperties the Invalid Entities should be calculated as part of the GetVolumeForGroup (and GetVolumeForGroupWidget). This should now return elements and invalid elements rather than two calls and two queries. Will half the processing time

candcconsulting commented 1 year ago

Resolved. getVolume routines now return validEntries and invalidEntries in the same call return {gwpList : returnList, errorList: errorList}; there is a redundant flag checkErrors, which could be removed.

These are actually the same and could have been combined as the routines do combine them, but enables a calling routine to utilise the errors immediately / separately if required