candiedoperation / marquer

Hassle-Free Image Flashing, Designed for elementary OS
GNU General Public License v3.0
21 stars 0 forks source link

Unnatural use of pagination #3

Closed hanaral closed 3 years ago

hanaral commented 3 years ago

Page dots are generally used with galleries and other types of non-layered menus (like the elementary onboarding window), so it's a bit odd to use it for a menu that's one layer deeper than the intro screen (also having the dots there makes it look like there is an another separate menu to the right) Keep up the good work!

candiedoperation commented 3 years ago

@hanaral, Requesting you to have a look at the linked pull request. I've implemented suggestions related to the carousel indicators.

hanaral commented 3 years ago

@candiedoperation I think lines do look better, but if you really want to show page indicators in a multi-layered menu, I can only suggest page numbers to more explicitly imply it isn't a gallery view (lines still don't specifically show that they are steps).

hanaral commented 3 years ago

Ok, so I've properly had the chance to test the app now, and think this issue should be re-opened; The the pagination makes the views seem unrelated - being able to swipe through a destructive action rather than being guided is dangerous and may result in user wiping disks accidentally

Here are the issues I see to be caused by the unnecessary pagination:

The simplest solution IMO is to just not use the swipe-y cool page changing, for the same reason elementary's installer doesn't. If you want to keep a page indicator, put a badge somewhere on the screen with the number of the step (don't let users use it as the mode of navigation though)