search

candle-usb / candleLight_fw

gs_usb compatible firmware for candleLight, cantact and canable
Other
623 stars 282 forks source link

RFC: consider pulling in ST HAL + CMSIS as submodules instead of local copy #82

Open fenugrec opened 2 years ago

fenugrec commented 2 years ago

drawback : those repos, even when shallow cloned, are huge. CubeF0 is > 300MB. But HAL alone, without CMSIS is around 7MB, this one could be acceptable. The CMSIS files probably aren't updated as often as the HAL drivers .

Daniel-Trevitz commented 1 year ago

Tiny USB is using: https://github.com/STMicroelectronics/stm32f0xx_hal_driver.git https://github.com/STMicroelectronics/stm32f4xx_hal_driver.git https://github.com/STMicroelectronics/cmsis_device_f0.git https://github.com/STMicroelectronics/cmsis_device_f4.git

When checked out they are currently 40MiB for the cmsis set, and 20MiB for the stm set. --depth=1 clone only drops 2MB for a total of 58MiB

Our paired-down version of all 4 combined is 6.8MiB, and includes our cmake support.

fenugrec commented 1 year ago

ah, this could help too :

$ man gitmodules ... submodule..shallow When set to true, a clone of this submodule will be performed as a shallow clone (with a history depth of 1) unless the user explicitly asks for a non-shallow clone.