search

candlefinance / faster-image

Fast image loading for React Native backed by performant native libraries.
https://candle.fi/discord
MIT License
594 stars 28 forks source link

resizeMode has no effect on base64Placeholder #68

Open vyobukhov opened 2 weeks ago

vyobukhov commented 2 weeks ago

Hi guys,

I've encountered a bug that appears to have been previously reported by @StasKovalov in the comments of another issue. However, it seems that it might have been overlooked and not addressed yet.

resizeMode has no effect on base64Placeholder. It just stretches it randomly.

Here is the link to the relevant comment for your reference: https://github.com/candlefinance/faster-image/issues/41#issuecomment-2178418843_

gtokman commented 2 days ago

Should be an easy fix by applying the resize mode here: https://github.com/candlefinance/faster-image/blob/e6f13256b4db961e29786edcac53f508848b7660/ios/FasterImageViewManager.swift#L359.

I don't have the bandwidth to take this on atm, but if you make a PR, I'll merge it!