resizeMode and borderRadius inconsistencies on Android

[nickvgn]

Hey. Thanks for promptly responding to the previous report. Found a couple more issues on android.

1. resizeMode not reflected and defaults to "contain"

   

2. borderRadius value doesn't match the React Native values (this is only on android as well). I have added a border radius of 10 on both the image an the view wrapping it. Added a border line in red to emphasise.

   

[gtokman]

@nickvgn thanks for filing this, I'll see if I can get it fixed later this week!

[arnekolja]

Setting overflow: 'hidden' in styles worked for me.

[arnekolja]

+1 for resize mode not working. Makes this one useless for me for now, sadly :-(

[gtokman]

@nickvgn resizeMode is fixed in the latest version!

[jamesholcomb]

In the repo example, you demonstrate circular images....if the Platform is android

style.image is borderRadius: (size - 16) / 2

and the RCTView prop is borderRadius: size * 2

is there a reason that conventional radius calculations of CSS can't be used consistently? it's cumbersome to remember to come up with and use different calculations, especially based on Platform.

[nickvgn]

thank you!

[gtokman]

In the repo example, you demonstrate circular images....if the Platform is android

style.image is borderRadius: (size - 16) / 2

and the RCTView prop is borderRadius: size * 2

is there a reason that conventional radius calculations of CSS can't be used consistently? it's cumbersome to remember to come up with and use different calculations, especially based on Platform.

It's because Android has some complexity when round corners. I'm keeping this issue open & will make it consistent next PR.

[efstathiosntonas]

i think the simple solution would be to apply overflow:hidden on the image styles or the container styles (or both)

[gtokman]

Fixed in latest pr! @jamesholcomb @nickvgn

[jamesholcomb]

A bit confused on how this fixes the issue I mentioned above (from March 30)?