search

candlepin / rho

ssh scanner for your network
GNU General Public License v2.0
32 stars 20 forks source link

Kbattula/osgeneric #23

Closed karthikhhr closed 8 years ago

karthikhhr commented 8 years ago

@barnabycourt Please take a look.
@cnsnyder

karthikhhr commented 8 years ago

Made the changes. The explanation for the first try block has been added. The exception from the second try block is captured because we don't want the execution of the entire program to be affected by a failure in the imports of items which we do not currently use. I fixed this by getting rid of the import altogether and also the portion of the Ordered Dict which we do not use for the (only) purpose of maintaining the key order

karthikhhr commented 8 years ago

@barnabycourt Please take a look now. I have made all the changes you pointed out + made the writing to csv thread safe by collecting all information and storing it in-memory before writing it to the csv locally.

barnabycourt commented 8 years ago

@karthikhhr

  1. The changes to the .gitignore are still needed.
  2. Please do not pull in OrderedDict. There are ways to accomplish this without creating a compatibility layer. For example, sorting the keys manually before iterating.
  3. Outside of github, I would like to see a sample of what a full collection of data looks like from a single RHEL 7 machine before signing off on an in-memory store of the data before writing to CSV.
barnabycourt commented 8 years ago

@karthikhhr The files are still failing flake8 checks and a few comment updates we discussed. The commits should also be squashed down to a single commit

karthikhhr commented 8 years ago

@barnabycourt I squashed the commits into 1 but I now have merge conflicts against rho-2 branch. I am not sure why this happened.

cnsnyder commented 8 years ago

A new branch has been created based on this for the new version of rho. (branch rho-2.0)

Closing as we can move forward on that branch.