search

candostdagdeviren / CDAlertView

Highly customizable alertview and alert/notification/success/error/alarm popup written in Swift
https://candostdagdeviren.github.io/CDAlertView/
MIT License
1.14k stars 86 forks source link

Additional customization options #32

Closed sgruby closed 6 years ago

sgruby commented 6 years ago

These changes do the following:

  1. Allow an action handler to prevent the alert from being dismissed. This is useful for checking the textfield for validation prior to the alert being dismissed.
  2. Added ability to set the keyboard type and auto correction type for the text field. Pretty straightforward.
  3. Added ability to turn off rounded corners. My usage requires square corners.
  4. If the top circle is clear, treat this as not showing the circle and shrink the header. My usage doesn't display the circle at the top.
candostdagdeviren commented 6 years ago

Wow! Thanks for submitting this awesome PR @sgruby. I took a look and I didn't see any issue in the first look. However, I will take a look at deeply and try as soon as possible. If it works, I will merge.

sgruby commented 6 years ago

Thanks! Your library has been working well in one of my projects, but the client had some specific customizations hence my changes.

sgruby commented 6 years ago

Do you want to make the changes to match your thinking? I appreciate you taking the time to review this and make suggestions on improving it.

candostdagdeviren commented 6 years ago

I want to make the changes but I don't have enough time in these days to do it myself. Do you have time to do it?

sgruby commented 6 years ago

I just made the changes. Please let me know if they work with your vision of the library.

Thanks!

candostdagdeviren commented 6 years ago

It looks awesome! I will merge and release a new version with a README update :) Thanks for awesome and quick work.

candostdagdeviren commented 6 years ago

Released with version 0.8.0

sgruby commented 6 years ago

Excellent, thanks!