search

candreoliveira / ngMask

Best Angular mask alternative! No jQuery, pure JS. About ~6kb!
http://candreoliveira.github.io/#/ngMask
ISC License
419 stars 171 forks source link

main is "Gruntfile.js" in package.json #83

Open aluanhaddad opened 8 years ago

aluanhaddad commented 8 years ago

Greetings,

I am working on a fairly large application and we are in the process of migrating from bower to jspm.

Unfortunately, while jspm handles most module formats automatically, including "globals" such as ngMask, the main property in package.json has what I believe to be the incorrect value of "Gruntfile.js".

That main does not point at dist/ngMask.js would be annoying in it's own right, as it would require manual configuration, but the real problem is that, since Gruntfile.js is a valid CommonJS module, the loader thinks that the package is that module and configures itself to load it on installation.

This issue relates to #35 opened by @atwright147, and would be resolved by his/her associated pull request #36.

Bodom78 commented 8 years ago

+1 Same issue here with JSPM

ale30p commented 8 years ago

+1 Same issue

aluanhaddad commented 8 years ago

It looks like this was recently fixed, however, I have also noticed that package.json does not specify a dependency on angular. Also, the new version is not on npm yet so you need to install via github. The following now works:

jspm install ng-mask=github:candreoliveira/ngMask -o "{ dependencies: { angular: '*' } }"
aluanhaddad commented 8 years ago

I opened https://github.com/candreoliveira/ngMask/pull/106 which, if merged, should remove the need for the override.