search

candrews / log4jdbc-spring-boot-starter

Starter for using Log4jdbc with Spring Boot
Apache License 2.0
77 stars 18 forks source link

added new property log4jdbc.spylogdelegator.name that is supported by log4jdbc #8

Closed jonseah closed 6 years ago

jonseah commented 6 years ago

… log4jdbc

candrews commented 6 years ago

Can you fix the typo in the commit message? I'll then merge this - thanks for the contribution!

jonseah commented 6 years ago

fixed typo

jonseah commented 6 years ago

Actually, i just noticed that at the end of the postConstruct that you have the following

System.setProperty("log4jdbc.spylogdelegator.name", this.environment.getProperty("log4jdbc.spylogdelegator.name", Slf4jSpyLogDelegator.class.getName()));

So my commit is redundant. I was debugging my app to see why that property was not being picked up but seems like my DataSource was being created before the postConstruct

jonseah commented 6 years ago

Last line of the postConstruct in Log4jdbcBeanPostProcessor already does this, no longer need this PR