search

candrholdings / slack-cli

A command line interface for Slack implemented using node.
https://candrholdings.github.io/slack-cli/
287 stars 31 forks source link

Update dependencies #26

Closed chrisui closed 1 year ago

chrisui commented 7 years ago

This updates dependencies so that the package works with later node versions.

Fixes https://github.com/candrholdings/slack-cli/issues/12

Note there is now a package-lock.json file which is a npm5 thing to ensure developers are on the same version of packages while working. This is NOT published to consumers. It is convention to commit it. Docs here.

chrisui commented 7 years ago

Build is running fine locally now with node 8. Since there are no tests just going to make sure that my usage of the cli is working as expected!

pho3nixf1re commented 7 years ago

I am looking forward to this change. Is everything checking out?

vzaidman commented 7 years ago

any updates on this?

vzaidman commented 7 years ago

with your PR, i got this error:

 /usr/local/lib/node_modules/slack-cli/bin/cmd.js:175
                return callback();
                       ^
TypeError: callback is not a function
    at async.auto.groups (/usr/local/lib/node_modules/slack-cli/bin/cmd.js:175:24)
    at runTask (/usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1619:13)
    at /usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1559:13
    at processQueue (/usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1569:13)
    at taskComplete (/usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1588:9)
    at /usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1612:17
    at /usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:906:16
    at checkArgs (/usr/local/lib/node_modules/slack-cli/bin/cmd.js:169:13)
    at runTask (/usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1621:13)
    at /usr/local/lib/node_modules/slack-cli/node_modules/async/dist/async.js:1559:13
vzaidman commented 7 years ago

i fixed this PR. now it works for me. https://github.com/candrholdings/slack-cli/pull/27

to anybody encounters this problem, go with:

npm install https://github.com/PowToon/slack-cli