candy-chat / candy

JavaScript-based multi-user chat client for XMPP.
http://candy-chat.github.io/candy
MIT License
1.32k stars 370 forks source link

Turn Notification message into a clickable URL #323

Closed GaryNiederhelman closed 9 years ago

GaryNiederhelman commented 9 years ago

I am trying to determine how to turn this line, from Candy.min.js (unminimized in my environment), into a clickable url, to a new window/tab:

c.getPreviousNick() && i && i.is(":visible") !== !1 || (a.Roster.joinAnimation(h), void 0 !== g && c.getNick() !== g.getNick() && a.Room.getUser(f) && ("chat" === a.Chat.rooms[f].type ? a.Chat.onInfoMessage(f, b.i18n.("userJoinedRoom", [c.getNick()])) : a.Chat.infoMessage(f, b.i18n.("userJoinedRoom", [c.getNick()]))))

I can't seem to follow what you are doing here - Ideally, what I'd like to see is when a user clicks on the message that is put in the message pane as a result of this line, they are taken to a url that we define in the js along with a url param with the value of a.Room.getUser(f) - which I think we understand is the 'full' name of the user.

mweibel commented 9 years ago

Don't work on candy.min.js or candy.bundle.js, as I said previously. In CONTRIBUTING.md there's a little how to work on Candy. It might help you.

I won't support further questions without these basic requirements.