candy:core.presence triggerhandler update

candy-chat / candy

JavaScript-based multi-user chat client for XMPP.

http://candy-chat.github.io/candy

MIT License

1.32k stars 370 forks source link

candy:core.presence triggerhandler update #332

Closed malakada closed 9 years ago

malakada commented 9 years ago

This trigger is used within Candy core here: https://github.com/mojolingo/candy/blob/dev/src/view.js#L69 which really calls this here: https://github.com/mojolingo/candy/blob/dev/src/view/observer.js#L150-L227

No where in that does it call args.from or args.stanza. So uh, I'm not really sure how this is working unless the functionality was fixed/duplicated somewhere else?

I'd like another set of eyes on this to make sure I'm not totally overlooking something.

malakada commented 9 years ago

Sorry, we put this on a fork and I should have made the PR over there. :)