search

candy-chat / candy

JavaScript-based multi-user chat client for XMPP.
http://candy-chat.github.io/candy
MIT License
1.32k stars 370 forks source link

Sort locales by language code #429

Closed GreenLunar closed 8 years ago

GreenLunar commented 8 years ago

I hope I did not break anything

benlangfeld commented 8 years ago

The indenting is inconsistent here. Please follow the tab convention. You'll also need to say something to justify the change.

GreenLunar commented 8 years ago

Does it look better?

benlangfeld commented 8 years ago

You still have not given me any good reason to merge this.

GreenLunar commented 8 years ago

Please assist me. I did sort translations according to language code and indent colons.

benlangfeld commented 8 years ago

I understand what you did. I do not really understand why, however. Right now this is a change for the sake of a change. I need some better reason for this to be written down.

GreenLunar commented 8 years ago

I did it so frivolous translators would not accidentally translate Candy into a language that is already available, because they thought that the languages are sorted already.

linkmauve commented 8 years ago

I think it would be better to have one file per translation, extending the Candy.View.Translation object if it already exists (look at other files in the repository for examples), and let the filesystem handle the sorting for you.

Otherwise, if you decide to keep this version, please move the English translation where it should be, there is no reason to have an exception to keep it on top imo.

Also, please rebase your commits together once you are done and ready for a merge.

benlangfeld commented 8 years ago

I think it would be better to have one file per translation

:+1:

GreenLunar commented 8 years ago

See https://github.com/candy-chat/candy/issues/479