search

candy-chat / candy

JavaScript-based multi-user chat client for XMPP.
http://candy-chat.github.io/candy
MIT License
1.32k stars 370 forks source link

Fix #456 to allow setup.sh to run correctly #458

Closed sww314 closed 8 years ago

sww314 commented 8 years ago
mweibel commented 8 years ago

so apt-get install doesn't require sudo but npm does require? now I'm confused ;)

sww314 commented 8 years ago

apt-get install still needs root access, but the entire script is run as root. When Vagrant runs the script (provision.sh), the whole script is run as root -- no sudo needed. I made it consistent to remove all sudo statements.

However, the npm and bower install want to be run as your local user (vagrant). Without these changes the script fails and you have /home/vagrant/.npm directory owned by root which causes weird errors latter. The sudo statement needs the -H to use the correct home directory for the vagrant user.

With theses changes you can simply: Pull repo cd candy ./setup.sh Goto http://localhost:8080/

I tested on my fork.

On Tue, Jan 26, 2016, 12:18 AM Michael Weibel notifications@github.com wrote:

so apt-get install doesn't require sudo but npm does require? now I'm confused ;)

— Reply to this email directly or view it on GitHub https://github.com/candy-chat/candy/pull/458#issuecomment-174851636.

mweibel commented 8 years ago

thanks :)