cangwolf / javamelody

Automatically exported from code.google.com/p/javamelody
0 stars 0 forks source link

Slf4j system, with log4j-over-slf4j, is not detected with version 1.7.6 of slf4j #378

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. import slf4j 1.7.6
2. configure log4j-over-slf4j

Java Melody should use slf4j system
but it use log4j.

I provide 2 patchs : one with a correction, another one with a simple unit test 
(in another module as i have to depend on slf4j)

Original issue reported on code.google.com by jgrag...@netceler.com on 12 Feb 2014 at 11:44

Attachments:

GoogleCodeExporter commented 9 years ago
The patch is included, thanks. And I prefer to not include the unit test 
because adding a new module for a unit test is a bit too much.

It's committed in trunk (revision 3676) and ready for the next release (1.50).

Original comment by evernat@free.fr on 12 Feb 2014 at 11:27

GoogleCodeExporter commented 9 years ago
okie. It's also possible to replace the dedicated test module with the 
maven-invoker-plugin

http://maven.apache.org/plugins/maven-invoker-plugin/usage.html

Since my bug request, I'have used this maven plugin for that exact kind of 
problem : create a module at runtime and run some tests on it. Works very well. 
if you wan't I can submit a patch.

Original comment by jgrag...@netceler.com on 13 Feb 2014 at 8:38

GoogleCodeExporter commented 9 years ago
Thanks, I did not know this plugin.
But don't bother: I am not a unit test addict enough to need that for this one 
line patch.

Original comment by evernat@free.fr on 13 Feb 2014 at 12:14