cangzhang / champ-r

🐶 Yet another League of Legends helper
GNU Lesser General Public License v2.1
1.73k stars 137 forks source link

Fixes for Linux on 2.0 version #277

Open NogradThGin opened 1 year ago

NogradThGin commented 1 year ago

Hello, some errors got into the code :yum:

Both on cmd.rs file.
First at line 18, there is 2 double quote a the end.
Actually: regex::Regex::new(r#"--install-directory=(.*?)""#).unwrap();
Instead of: regex::Regex::new(r#"--install-directory=(.*?)"#).unwrap();

And with ps command at line 69:
Actually: let cmd_str = r#"ps -A | grep LeagueClientUx | grep remoting-auth-token="#;
Instead of: let cmd_str = r#"ps aux | grep LeagueClientUx | grep remoting-auth-token="#;

Actually maybe ps -A is used for MacOS, I don't know. But as far as I tested, it doesn't work on Linux.

cangzhang commented 1 year ago

Hi, thx for your feedback, ps -A | grep LeagueClientUx | grep remoting-auth-token= is actually for macOS. Sorry I don't have a linux OS on my pc, since you have already there, contributions are welcome 😄

EatedPantsu commented 9 months ago

Hello! I'm willing to test the building and running under Linux, but I'd appreciate some help in compiling the package.

Hello, some errors got into the code

Both on cmd.rs file. First at line 18, there is 2 double quote a the end. Actually: regex::Regex::new(r#"--install-directory=(.*?)""#).unwrap(); Instead of: regex::Regex::new(r#"--install-directory=(.*?)"#).unwrap();

And with ps command at line 69: Actually: let cmd_str = r#"ps -A | grep LeagueClientUx | grep remoting-auth-token="#; Instead of: let cmd_str = r#"ps aux | grep LeagueClientUx | grep remoting-auth-token="#;

Actually maybe ps -A is used for Faggot_Os, I don't know. But as far as I tested, it doesn't work on Linux.

I've applied those changes but the build fails.

I'm using cargo b --target "x86_64-unknown-linux-gnu" but the app crashes after selecting sources and it does not detect league