canihavesomecoffee / theTVDbAPI

PHP implementation for the 2nd version of the TheTVDb API

ISC License

11 stars 8 forks source link

Fix issues with having null values for firstAired and network attributes #5

Closed DariusIII closed 4 years ago

DariusIII commented 4 years ago

Attributes firstAired and network are sometimes having null values which is causing exceptions to be thrown.

codecov[bot] commented 4 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             master     #5   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      166    166           
=======================================
  Files            25     25           
  Lines           461    461           
=======================================
  Hits            461    461

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 562e8c9...91283db. Read the comment docs.

canihavesomecoffee commented 4 years ago

@DariusIII Thanks for the fix 🥇. It's a shame the API is so loose with returning null on almost all fields though...

DariusIII commented 4 years ago

@canihavesomecoffee Their v3 API needs a lot of tweaking, as far as i can tell.

canihavesomecoffee commented 4 years ago

Feel free to open more PR's if you spot other things I might have missed :)

I've released 1.2.2 with your fix included.

DariusIII commented 4 years ago

As i am using your work extensively, as soon as i notice something will do a PR, if you haven't fixed it before me.