search

canismarko / dungeon-sheets

A tool to create character sheets and GM session notes for Dungeons and Dragons fifth edition (D&D 5e).
https://dungeon-sheets.readthedocs.io/en/latest/
GNU General Public License v3.0
161 stars 66 forks source link

Blood Hunter Class #118

Closed plsaddbloodhunter closed 2 years ago

plsaddbloodhunter commented 2 years ago

I hope this is the right way to send you the script i coded. It works locally i renamed the feature files for upload purposes. Sorry if i made something wrong

canismarko commented 2 years ago

It's close. The idea with a pull request is to have your repository contain exactly the changes you think should be made to the upstream repo. In this case, those files don't belong in the top level of the repository. Would you mind making these changes so that I can easily compare?

  1. Move bloodhunter.py to dungeonsheets/classes/bloodhunter.py
  2. Move bloodhunterFeature.py to dungeonsheets/features/bloodhunter.py``
  3. Remove __init__.py from the top level and instead make those changes to dungeonsheets/classes/__init__.py
  4. Remove __init__Feature.py from the top level and instead make those changes to dungeonsheets/features/__init__.py.
  5. Create a new file examples/bloodhunter1.py that shows how a blood hunter character would be defined for a character sheet.

Thanks!