search

canismarko / dungeon-sheets

A tool to create character sheets and GM session notes for Dungeons and Dragons fifth edition (D&D 5e).
https://dungeon-sheets.readthedocs.io/en/latest/
GNU General Public License v3.0
161 stars 66 forks source link

sorry for the delay #119

Closed plsaddbloodhunter closed 2 years ago

plsaddbloodhunter commented 2 years ago

Sorry if i didn't make the changes right after your response,but I'm currently studying for the upcoming school exams and i don't have much free time any more. I hope i made all the right correction and that i didn't mess up. Thank you so much for the help and the patience

canismarko commented 2 years ago

No problem, we all have lives outside of D&D, or at least so I've been told =P

The structure looks good and I think it's close. Right now the example doesn't build. So it needs a few small changes to get it working properly:

dungeonsheets/features/bloodhunter.py

Right now you have

from dungeonsheets.features.ranger import Archery, Dueling, GreatWeaponFighting, TwoWeaponFighting

but GreatWeaponFighting is defined in dungeonsheets.features.fighter, not ranger.

example/bloodhunter1.py

You named the class BloodHunter(), in the example you refer to it that way. The strings used in the character files get converted when resolving them to actual class definitions, and "BloodHunter" becomes Bloodhunter(), not BloodHunter() (notice the capitalization). You'll need to change the example so that

classes = ['Blood hunter']

Similar thing is happening with the subclass: "Order of the Ghost Slayer" gets resolved to OrderOfTheGhostSlayer(), but the class is actually OrderOfTheGhostslayer(), so the example should read:

subclasses = ["Order of the Ghostslayer"]