canismarko / dungeon-sheets

A tool to create character sheets and GM session notes for Dungeons and Dragons fifth edition (D&D 5e).
https://dungeon-sheets.readthedocs.io/en/latest/
GNU General Public License v3.0
163 stars 67 forks source link

Enhancement proposal: companions and summonable creatures #121

Open bw-mutley opened 2 years ago

bw-mutley commented 2 years ago

Hi there, Mark. I got some days to work on this project, so I thought about some improvements. One of them is to include a compiled list of companions and summonable creatures in a similar way it is done to druid shapes. It would be a matter of including a few lines to make_sheets.py. Also, I would like to ask you which issues are real priorities, it seens like the issues list is not updated. Let me know how can I be of help.

canismarko commented 2 years ago

That sounds great! And I agree, should be straightforward.

88 could use a fix. #102 would be good, but I don't know if it gets used much. I really would like to get #75, but I don't know if a solution to that one exists.

Thanks for your efforts.

bw-mutley commented 2 years ago

Hi Mark, I've just made 4 pull requests - sorry if it is 'messy', I don't know how to make just a single one since the changes were in different folders. I've included a small report of changes in one of the commits. I've tested them using .tex and .html forms, but not epub. Let me know if any issues.

==EDIT, 02/16== Seens like you didn't have time to check the pull requests. I've made some other improvements. This time I added Carrying Weight and capacity to Character class. I will wait for you to see what is better at this time, maybe we should cancel the pull request and make a single update. Let me know when it is a better time for you. Best regards.

canismarko commented 2 years ago

@bw-mutley yeah we just had a baby so things have been hectic. Can you let me know which of the 4 PR's I should look at? I can work on it while baby is napping on me at some point.

Thanks!

bw-mutley commented 2 years ago

Hey Mark! Congratulations for the baby! As for the pull requests: I did it wrong, there were changes in 4 folders and I didn't know how to proceed so ended making 4 requests. I guess we can cancel and I pull a single one including other things I've done after this one. Let me know what is best and I will organize things here.

canismarko commented 2 years ago

Thanks!

I'd prefer to have 1 PR, thanks.