canismarko / dungeon-sheets

A tool to create character sheets and GM session notes for Dungeons and Dragons fifth edition (D&D 5e).
https://dungeon-sheets.readthedocs.io/en/latest/
GNU General Public License v3.0
163 stars 67 forks source link

Add Github actions testing #130

Closed meson800 closed 2 years ago

meson800 commented 2 years ago

This converts the existing travis CI to Github CI, possibly closing #108. I plan on possibly submitting more PRs, so set this up on my fork to test my edits and thought it could be useful here! Github actions are free for public repos too :)

Notes

    - name: Coveralls
      if: always()
      uses: coverallsapp/github-action@master
      with:
        github-token: ${{ secrets.GITHUB_TOKEN }}

The if: always() line means that we can "fail the GHA build" with a failing test, but it will still always upload coverage to Coveralls.

canismarko commented 2 years ago

Thanks for the PR.

The flake run shows a lot of warnings, so not sure if this correctly pulls in any necessary flake config.

No idea. I keep meaning to setup a pre-commit hook to format using black, so that might fix some of the warnings.