search

canismarko / dungeon-sheets

A tool to create character sheets and GM session notes for Dungeons and Dragons fifth edition (D&D 5e).
https://dungeon-sheets.readthedocs.io/en/latest/
GNU General Public License v3.0
161 stars 66 forks source link

Lucky #136

Closed kloetzl closed 1 year ago

kloetzl commented 1 year ago

There are two features called lucky. One is the Halfling's luck the other is the feat with the three luck points. This is an unfortunate name clash. I think it is easier to rename the Halfling's luck as that is not usually added manually to a character.

canismarko commented 1 year ago

@kloetzl Thanks for submitting this. I agree it's an issue. A recent PR (https://github.com/canismarko/dungeon-sheets/pull/139) fixed this for a different name clash between features.

I think your suggestion of renaming the Halfling's luck ("HalflingLuck"?) is a good choice. Are you interesting in preparing a PR?

kloetzl commented 1 year ago

Sure, I'll go ahead and create a PR.