search

canismarko / dungeon-sheets

A tool to create character sheets and GM session notes for Dungeons and Dragons fifth edition (D&D 5e).
https://dungeon-sheets.readthedocs.io/en/latest/
GNU General Public License v3.0
163 stars 67 forks source link

Spelling fixes and seven bug fixes #166

Closed PJBrs closed 1 month ago

PJBrs commented 5 months ago

This PR contains three patches. One corrects spelling from sorceror to sorcerer. I've added a check that still accepts sorceror as class in a character file to keep backwards compatibility.

Another patch adds loads and loads of spelling fixes, as well as various formatting fixes. I've gone over several files semi-structuredly. Only the bloodhunter files are still very hard to check, and they do contain various spelling errors.

A final patch, I think, contains a bug fix, where the VERSION file isn't added to the package anymore since the move to the pyproject.toml file. I haven't made a bug report for that one, but at least for me the resulting package without the third patch did not work.

PJBrs commented 3 months ago

@canismarko - I hope you can pull these soon? They all just seem straightforward and self evident to me.

By the way, I'd be more than happy to meet on Discord to discuss my patches with you in detail. Maybe that would make it easier to decide on my contributions? I'm pjbrs on Discord (or PJBrs), just drop me a line there. I'm in Central European Summer Time (CEST; UTC+2).

PJBrs commented 3 months ago

@canismarko I went over the issue list for dungeon-sheets and decided to fix what I could. I added fixes for: https://github.com/canismarko/dungeon-sheets/issues/25 https://github.com/canismarko/dungeon-sheets/issues/48 https://github.com/canismarko/dungeon-sheets/issues/150 https://github.com/canismarko/dungeon-sheets/issues/83 https://github.com/canismarko/dungeon-sheets/issues/29

And I bug fix where the number of subclasses makes makesheets crash when one class does have a subclass and another doesn't in the user's character file.

canismarko commented 3 months ago

@canismarko - I hope you can pull these soon? They all just seem straightforward and self evident to me.

By the way, I'd be more than happy to meet on Discord to discuss my patches with you in detail. Maybe that would make it easier to decide on my contributions? I'm pjbrs on Discord (or PJBrs), just drop me a line there. I'm in Central European Summer Time (CEST; UTC+2).

Perhaps we should discuss on discord. I'd like to reset and figure out how to get this all done smoothly. I sent you a friend request.