canisminor1990 / factorio-gridlines

🧇 Enhance your building layouts with a powerful and flexible grid system! Gridlines adds customizable grids to your world, allowing for precise and efficient designs across multiple layers.
https://mods.factorio.com/mod/gridlines
GNU General Public License v3.0
4 stars 0 forks source link

This line breaks other mods #5

Open ddamiani opened 4 days ago

ddamiani commented 4 days ago

https://github.com/canisminor1990/factorio-gridlines/blob/e95193f40086fdcf551ed7c76ddb5e9c11400af4/src/app/clean.ts#L5

This code as written blows away all rendering objects not just the ones created by the mod. This breaks any other mod that is creating its own rendering. this should be:

rendering.clear('factorio-gridlines');

to only touch the things rendered by this mod.

canisminor1990 commented 4 days ago

👀 @ddamiani Thank you for raising an issue. We will investigate into the matter and get back to you as soon as possible. Please make sure you have given us as much context as possible.\ 非常感谢您提交 issue。我们会尽快调查此事,并尽快回复您。 请确保您已经提供了尽可能多的背景信息。