search

canitzp / FeederHelmet

Upgrade all your loved helmets, so they feed you while you do nothing
Other
2 stars 3 forks source link

compatible Nutrition #11

Closed axin0452 closed 5 years ago

axin0452 commented 5 years ago

It does not increase nutritional value when it is eaten automatically.

WesCook commented 5 years ago

Nutrition mod author here. I marked this as closed on my side because I believe it's best implemented on this side by emulating the appropriate event.

But let me know if you run into any issues.

canitzp commented 5 years ago

So it works when I fire the finish event after I called the item method?

WesCook commented 5 years ago

I haven't tested, but that would be my guess!

canitzp commented 5 years ago

@WesCook I fixed this by adding the finish event (I also added the start event), but only in the latest mc version, 1.14.x. I probably won't fix older version, if it isn't mandatory. How are your plans of updating to 1.14?

Jecvay commented 5 years ago

as sponge claimed 1.12.2 as a long term support version these days, can you fixed 1.12.2 for a more widely effect ?

WesCook commented 5 years ago

How are your plans of updating to 1.14?

Haven't even started looking into it yet! It's on the docket, though.

canitzp commented 5 years ago

I'll try to create a 1.12.2 fixed version, but idk if I can

Jecvay commented 5 years ago

thanks

canitzp commented 5 years ago

@Jecvay @WesCook FeederHelmet-1.4.1 is now uploaded to curseforge. This is a 1.12.x version with the two events, but I haven't tested if it actually fixes the issue