canitzp / FeederHelmet

Upgrade all your loved helmets, so they feed you while you do nothing
Other
2 stars 3 forks source link

[Bug] Helmet doesn't take energy from Construct Armory's Fluxed/Energized Modifier #30

Closed Desempregago closed 2 years ago

canitzp commented 2 years ago

Can you show me the exact helmet used for this?

Desempregago commented 2 years ago

2022-04-25_01 18 12 2022-04-25_01 18 15

Desempregago commented 2 years ago

Neither durability nor energy gets consumed.

canitzp commented 2 years ago

Oh well it is draconic evolution again. I fixed a issue with the wyvern armor before. There is no "good" way for me fixing this issue and since you already have an unbreakable armor, you're probably pretty endgame, and so this issue is not crucial. While reading the code I noticed that it "should" use up some energy from the helmet, but it isn't really noticeable and probably already refilled by the solar module.

Desempregago commented 2 years ago

the thing is, it happens even with other modules, like Fluxed Electrum, which also includes energy via the Energized trait.

Desempregago commented 2 years ago

it's not just Draconic. Also, the module BREAKS the helmet (the helmet item just vanishes), even if "durability necessary" is set to 1 (default config value) on Tinkers' Construct helmets (any helmet combination). It's probably bypassing the "broken" state of the helmet

Desempregago commented 2 years ago

While reading the code I noticed that it "should" use up some energy from the helmet, but it isn't really noticeable and probably already refilled by the solar module.

It doesn't take energy, but also doesn't work (doesn't feed the player)

canitzp commented 2 years ago

Cloud you please provide the name of the modpack? It would make most sense, if I can test it there

Desempregago commented 2 years ago

It's a self made pack. I can send you the google drive link if you want

Desempregago commented 2 years ago

https://drive.google.com/file/d/1Puo1xtg6umXkLVGAMCwA6w4n23z4W3LT/view?usp=sharing

canitzp commented 2 years ago

Thank you for the link. I already tested the wyvern helmet and the feeding does infact work like it is designed. It does not work when the helmet is empty and it starts to work as soon as it has power. I also saw that it consume a little bit of energy, while consuming.

Desempregago commented 2 years ago

So it seems it's something on my end then?

canitzp commented 2 years ago

No it is not, I have found a problem with the energy handling. ConstructsArmory uses a different nbttag, when a "wyvern" armor is in use. Instead of "Energy" it is called "EvolvedEnergy". This of course can't be handled by the feeder module, leading to it not working at all.

canitzp commented 2 years ago

@Desempregago Please try this version out: https://filetransfer.io/data-package/AaEOUTQ2#link

Desempregago commented 2 years ago

It's perfect. Doesn't "void" (deletes) non-electric helmets anymore PLUS fixes the problem of not consuming energy. Many thanks :)

Desempregago commented 2 years ago

Found a bug:

https://user-images.githubusercontent.com/14002834/165076859-2a44fe64-e578-473b-8b0a-d87e6a368b3a.mp4

Desempregago commented 2 years ago

Happens with ANY helmet, doesn't need to be a Construct Armory helmet

canitzp commented 2 years ago

Oh well, I have fixed this issue in a newer mc version already

canitzp commented 2 years ago

@Desempregago try this one: https://filetransfer.io/data-package/ddMb3J9O#link

Desempregago commented 2 years ago

Will do later today. Thank you for your time.