search

canjs / bit-docs-html-canjs

The plugins to produce CanJS.com
https://www.npmjs.com/package/bit-docs-html-canjs
MIT License
7 stars 0 forks source link

New Copy & Run button styles implementation #568

Closed cherifGsoul closed 4 years ago

cherifGsoul commented 4 years ago

Fixes #561 Depends on https://github.com/bit-docs/bit-docs-html-codepen-link/pull/14

Screen Shot 2019-08-13 at 5 22 05 PM Screen Shot 2019-08-13 at 5 22 12 PM Screen Shot 2019-08-13 at 5 22 16 PM Screen Shot 2019-08-13 at 5 22 25 PM Screen Shot 2019-08-13 at 5 22 38 PM Screen Shot 2019-08-13 at 5 22 52 PM
cherifGsoul commented 4 years ago

This doesn’t look quite right (buttons over the expand bar):

What is not right, the style or Run button is missed?

I don’t see the Run button integrated into the toolbar. Should that be in this PR?

@chasenlehara did you update bit-docs-html-codepen-link to major? https://github.com/canjs/bit-docs-html-canjs/blob/5543af358184a36f2257c77f7ced9d1d9d6990b2/make-example.js#L31

cherifGsoul commented 4 years ago

@chasenlehara I updated the styles, for notes, buttons toolbar is a sibling to the collapsible bar parent. I updated the make-example.js with the last major of bit-docs-html-codepen-link