canjs / can-connect-feathers

The FeathersJS client library for DoneJS and can-connect

https://canjs.com/doc/can-connect-feathers.html

MIT License

10 stars 4 forks source link

call super's init method #103

Closed green3g closed 6 years ago

green3g commented 6 years ago

76

justinbmeyer commented 6 years ago

Thanks for the PR. We'll see eventually what's going on with the build. (We are currently under-staffed (I just had a baby, Chasen is on a client), so any help others can give in the next few weeks is greatly appreciated).

green3g commented 6 years ago

Poke @christopherjbaker

chasenlehara commented 6 years ago

Hey @roemhildtg, sorry this hasn’t been merged in yet. I’m back on open source and think I can take a look at the build issue either tomorrow afternoon or Monday. Sorry for the delay, we really appreciate you submitting PRs. 😊

chasenlehara commented 6 years ago

@roemhildtg If you have a moment, could you merge or rebase with master? I think I know what’s going on and would like to see if the tests will partially run now.

green3g commented 6 years ago

@chasenlehara I updated this. Still failing for some reason.

chasenlehara commented 6 years ago

@roemhildtg It looks like Travis doesn’t set the environment variables required to make Sauce Labs work when PRs are made from someone outside the org, which was why it was failing. Sorry it took a while to get this merged & released, but it’s in 4.0.1 now!