search

canjs / can-connect-feathers

The FeathersJS client library for DoneJS and can-connect
https://canjs.com/doc/can-connect-feathers.html
MIT License
10 stars 4 forks source link

feathers-error dep #140

Open Mattchewone opened 5 years ago

Mattchewone commented 5 years ago

The dependency for feathers-errors needs to be updated as the package has changed https://github.com/canjs/can-connect-feathers/blob/master/package.json#L62

It should now be @feathersjs/errors as the package

chasenlehara commented 5 years ago

Note that @feathersjs/errors wasn’t published before 3.x, so taking on this issue means upgrading everything for Feathers 3.

MarcGodard commented 5 years ago

@Mattchewone and @chasenlehara Is it possible to update this package to Can v5.x+ and Feathers v4+ ?Is there anything I can do to help? I am using query logic now and this lib is also still looking for algebra...

matthewp commented 5 years ago

I'm going to do a spike today to see what it would take to upgrade this.

MarcGodard commented 5 years ago

@matthewp Much appreciated.

matthewp commented 5 years ago

I have my progress here: https://github.com/canjs/can-connect-feathers/tree/feathers4

I was able to get a little over half of the tests passing. The biggest difference seems to be that authentication stopped using passport and can-connect-feathers did some stuff using passport and that part needs to change. There's also some timing issues where if a test runs by itself it passes but when run with all of them it fails. I'm not sure what that is about.

My guess is that it's probably another couple of days of work to get the upgrade done.

MarcGodard commented 5 years ago

@matthewp Much appreciated. Once I am caught up with my work, I will see if I can help.