search

canjs / can-connect-feathers

The FeathersJS client library for DoneJS and can-connect
https://canjs.com/doc/can-connect-feathers.html
MIT License
10 stars 4 forks source link

Behaviour Hooks not calling super() #76

Closed christopherjbaker closed 6 years ago

christopherjbaker commented 7 years ago

None of the hooks on either behaviour call the super equivalent on tho previous behaviour. I believe each should have baseConnect.<hook>.apply(this, arguments);, or am I mistaken?

green3g commented 6 years ago

Yep, this appears to be a bug. It prevents the other behaviors from working.

Like this line fails:

https://github.com/canjs/can-connect-feathers/blob/master/session/session.js#L36

frank-dspeed commented 6 years ago

@justinbmeyer please review and merge if its good looking

chasenlehara commented 6 years ago

Fixed by https://github.com/canjs/can-connect-feathers/pull/103 and released in 4.0.1