Closed mickmcgrath13 closed 6 years ago
Also, the whole _saving
and _destroying
stuff seems rather tedious to me.. should those values be added automatically like that? Wouldn't that mean that anyone who wants to use .save
would need to define _saving
and _destroying
?
all above issues fixed by updating more of the dependencies :)
Not Fixed
Error
in
session/session_tests-x-provider.js
, thehandler
method never gets called. It is making the assumption that theSession.on('current', handler)
will be called when a session is created, and that doesn't seem to be happening anymore.Needs fix
Did the binding of a constructor event change?
Error
Files not found:
Needs fix
Why are these files not found? Are they causing problems?
Error
Unhandled promise rejection -> NotAuthenticated
Is this an issue?
Fixed
Error
can-connect/can/map/map must be configured with a List type
Fixed by
Add list to the session defineMap
Error
Cannot define property _saving, object is not extensible
Fixed by
define
_saving
property on User defineMapError
Cannot define property _destroying, object is not extensible
Fixed by
define
destroying
property on User defineMapError
A bunch of these failures:
Fixed by
Adding
_saving
and_destroying
to Message DefineMap in service/service_tests-x-provider.jsError
A bunch of tests were failing due to a deepEqual of a pre-saved map and a map retrieved via .find. They were different because .save adds
_saving
and_destroying
and one map had those props while the other didn't.Fixed by
I worked around this issue for now calling
.serialize()
on both maps which (somehow) makes them both have_saving
and_destroying
. (?? not sure what's going on there).