search

canjs / can-connect

Model layer utilities for every JavaScript framework! Assemble real-time, high performance, restful data connections.
https://canjs.com/doc/can-connect.html
MIT License
29 stars 16 forks source link

Reference beforeSend in service guide and improve highlighting #499

Closed justinbmeyer closed 5 years ago

justinbmeyer commented 5 years ago

https://canjs.com/doc/can-connect/data/url/url.url.html

The examples are not highlighted:

image

They also are not codepen-able.

Finally, we should link to beforeSend in the guide around here: https://canjs.com/doc/guides/data-configuring-requests.html#CustomizingtherequestmethodandURL

nlundquist commented 5 years ago

Added link to beforeSend in guide: https://github.com/canjs/canjs/pull/5311 https://github.com/canjs/can-connect/pull/502

nlundquist commented 5 years ago

Added codepen examples to #502

phillipskevin commented 5 years ago

so can this be closed @nlundquist? or is there more to do?